750-auth

by infinitewarp 3 years ago

macOS ◆ xterm-256color ◆ bash 249 views

only create users when necessary

The original issue’s acceptance criteria suggests that any authentication failures should return 404s, not 403s. However, after more thoroughly experimenting with the API and seeing Django and DRF’s native/default behaviors for handling failed or missing authentication, I don’t believe strictly returning 404 is appropriate.

Our original concern was that by returning 401 or 403 instead of 404 we could leak information about other users and accounts. For example, maybe a malicious user would troll through IDs under /instances/{id}/ to infer what IDs might exist. However, the existence checks come after any required auth checks. So, it’s not possible to get information this way. Other than IDs, there’s nothing we have to hide in our public APIs since they are all publicly defined both in source code and in the openapi.json.

I think another reason we considered returning 404 was that it would be a cheaper implementation; that was a faulty assumption because the implementation is cheap and easy using more “correct” 403 status codes anyhow.

More by infinitewarp

579-pilot-rename-periodic-tasks 01:04

by infinitewarp 5 years ago

combine two git repo histories 00:50

by infinitewarp 5 years ago

339-kombu-is-dead-long-live-boto3 01:15

by infinitewarp 6 years ago

basic disk file creation to test houndigrade 02:11

by infinitewarp 5 years ago

See all

You can download this recording in asciicast v2 format, as a .cast file.

Download

Replay in terminal

You can replay the downloaded recording in your terminal using the asciinema play command:

asciinema play 382644.cast

If you don't have asciinema CLI installed then see installation instructions.

Use with stand-alone player on your website

Download asciinema player from the releases page (you only need .js and .css file), then use it like this:

<!DOCTYPE html>
<html>
<head>
  <link rel="stylesheet" type="text/css" href="asciinema-player.css" />
</head>
<body>
  <div id="player"></div>
  <script src="asciinema-player.min.js"></script>
  <script>
    AsciinemaPlayer.create(
      '/assets/382644.cast',
      document.getElementById('player'),
      { cols: 130, rows: 38 }
    );
  </script>
</body>
</html>

See asciinema player quick-start guide for full usage instructions.

While this site doesn't provide GIF conversion at the moment, you can still do it yourself with the help of asciinema GIF generator utility - agg.

Once you have it installed, generate a GIF with the following command:

agg https://asciinema.org/a/382644 demo.gif

Or, if you already downloaded the recording file:

agg demo.cast demo.gif

Check agg --help for all available options. You can change font family and size, select color theme, adjust speed and more.

See agg manual for full usage instructions.